<URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 >

2008/6/22 Jason Dorje Short:
> I'd suggest using valgrind to find the exact line where the error occurs
> here and to make sure the fix actually fixes and doesn't just hide the
> error.

 Valgrind can show only the point where actual illegal memory access
is made, which in this case caused segfault. It cannot tell when the
variable gets illegal pointer assigned. Traditional debugging shows
that player_ptr is NULL when entering game_renumber_players() and gets
set there. Patch fixes that.
 Only possible 'hidden' error is that player_idx is not set to special
flag value like -1.

 - ML

Freeciv-dev mailing list

Reply via email to