<URL: http://bugs.freeciv.org/Ticket/Display.html?id=40338 >

2008/6/29 Jason Dorje Short:
>
> Marko Lindqvist wrote:
>>
>> 2008/6/28 Jason Dorje Short:
>>> -      if (DEFAULT_LAKE_SEA_SIZE < ocean_sizes[-here]
>>> +      if (terrain_control.lake_max_size >= ocean_sizes[-here]
>>>            && num_laketypes > 0) {
>>>          tile_change_terrain(ptile, lakes[myrand(num_laketypes)]);
>>>
>>> Isn't this check backwards?
>>
>>  "If size of the body of water (right side) is smaller or equal to
>> maximum size of lake (left side), it's lake."
>
> Err.  Right.  So then...isn't the old check backwards?

 Yes.

 This code is used only if body of water is completely surrounded by
one continent. Potential lakes rarely appear with default landmass.
Lake creation code has probably not been tested before now.


 - ML



_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to