<URL: http://bugs.freeciv.org/Ticket/Display.html?id=40384 >

On Sat, Jul 19, 2008 at 5:10 PM, Marko Lindqvist <[EMAIL PROTECTED]> wrote:
>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=40384 >
>
> 2008/7/20 Jason Dorje Short:
>>
>> It's only illegal in that particular assertion.  Fix the assertion and
>> that is fixed!  Though for backwards compatibility with old clients
>> 2.1 may prefer a workaround.
>
>  What assertion you are talking about? Client is crashing because
> phase number is considered to be same as number of active player and
> 32 is illegal player number. Still, now I looked it, it seems to be
> almost trivial to fix (in the client end. If we want to fix it so that
> new server is not crashing old clients, my original patch is the only
> solution)

The phase number is the ID of the active player.  If it's
game.nplayers that means there is no active player, which is correct
in between turns.  Although rather than set it to game.nplayers for
such a case it might make more sense if it were -1?

-jason



_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to