<URL: http://bugs.freeciv.org/Ticket/Display.html?id=40389 >

2008/7/22 Jason Dorje Short:
> And what's the purpose of the return value anyway?  Wouldn't the
> simplest fix be just to change the != to < in the three comparisons?

 It would work, but I consider it very ugly. We would be looking in
the results of side effects and guessing from that the reasons to
these side effects.

> On the other hand changing the function to return the new value (a
> struct player_economic) so that it didn't have side effects, might be
> worthwhile.

 Yes, that would probably be the cleanest solution.

 - ML

Freeciv-dev mailing list

Reply via email to