<URL: http://bugs.freeciv.org/Ticket/Display.html?id=40484 >

In a locally compiled svn copy of 2.2.99 on Aug 20, compiled for the
GTK2 client on Linux, I discovered that the description of the Solar
Plant only matched what it actually did in limited circumstances.

The help text for Solar Plant says "Eliminates all pollution generated
by production in a city." (copied from buildings ruleset) But this is
not entirely true.  It does so only under certain unintuitive
conditions.  If you have a city with a factory and a Solar Plant that
is producing pollution, you can stop this by building a Mfg Plant,
unless you have the Hoover Dam somewhere.  If you have a city with a
factory, Mfg Plant, Recycling center and Solar Plant, it may produce
pollution.  To fix this, sell the recycling center, unless you also
have the Hoover Dam somewhere.  If you have built the Hoover Dam, you
cannot build Solar Plants anywhere.  Also, in the default ruleset, if
you have a Solar Plant, you can still build a Power Plant, Hydro Plant
or Nuclear plant.  If you have a Power Plant, you can still build Hydro 
or Nuclear.  If you have a Hydro Plant, you can still build Nuclear.
To have one of everything, build the Solar Plant, then Power Plant,
then Hydro, then Nuclear.  They will all cost upkeep, but only the
last one built will do anything.


I've made some changes to a ruleset that appear to fix these problems,
but there are side effects: you cannot build the Hoover Dam in a city
that already has a Solar Plant; and you can build a Solar Plant in a
city that already has a Power Plant, Hydro Plant, Nuclear Plant or
even the Hoover Dam, but only the Solar Plant will reduce pollution
(by 100%).  If you have the Hoover Dam, the city will get its
production bonus from it, or from the Solar Plant otherwise.
With the patch applied, the other three power plants now appear to be
mutually exclusive, as the help text specifies them to be.

The patch only affects data/default/effects.ruleset

------------------------------------------------------------------------

--- data/default/effects.ruleset        2008-08-24 04:52:56.000000000 -0600
+++ data/alt/effects.ruleset    2008-08-26 12:02:35.000000000 -0600
@@ -1012,7 +1012,9 @@
nreqs   =
     { "type", "name", "range"
       "Building", "Hoover Dam", "Player"
+      "Building", "Power Plant", "City"
       "Building", "Nuclear Plant", "City"
+      "Building", "Solar Plant", "City"
     }

[effect_hydro_plant_1]
@@ -1027,7 +1029,9 @@
nreqs   =
     { "type", "name", "range"
       "Building", "Hoover Dam", "Player"
+      "Building", "Power Plant", "City"
       "Building", "Nuclear Plant", "City"
+      "Building", "Solar Plant", "City"
     }

[effect_hydro_plant_2]
@@ -1042,7 +1046,9 @@
     { "type", "name", "range"
       "Building", "Recycling Center", "City"
       "Building", "Hoover Dam", "Player"
+      "Building", "Power Plant", "City"
       "Building", "Nuclear Plant", "City"
+      "Building", "Solar Plant", "City"
     }

[effect_hydro_plant_3]
@@ -1057,7 +1063,9 @@
     { "type", "name", "range"
       "Building", "Recycling Center", "City"
       "Building", "Hoover Dam", "Player"
+      "Building", "Power Plant", "City"
       "Building", "Nuclear Plant", "City"
+      "Building", "Solar Plant", "City"
     }

[effect_library]
@@ -1117,6 +1125,9 @@
nreqs   =
     { "type", "name", "range"
       "Building", "Hoover Dam", "Player"
+      "Building", "Solar Plant", "City"
+      "Building", "Power Plant", "City"
+      "Building", "Hydro Plant", "City"
     }

[effect_nuclear_plant_1]
@@ -1131,6 +1142,9 @@
nreqs   =
     { "type", "name", "range"
       "Building", "Hoover Dam", "Player"
+      "Building", "Solar Plant", "City"
+      "Building", "Power Plant", "City"
+      "Building", "Hydro Plant", "City"
     }

[effect_nuclear_plant_2]
@@ -1145,6 +1159,9 @@
     { "type", "name", "range"
       "Building", "Recycling Center", "City"
       "Building", "Hoover Dam", "Player"
+      "Building", "Solar Plant", "City"
+      "Building", "Power Plant", "City"
+      "Building", "Hydro Plant", "City"
     }

[effect_nuclear_plant_3]
@@ -1159,6 +1176,9 @@
     { "type", "name", "range"
       "Building", "Recycling Center", "City"
       "Building", "Hoover Dam", "Player"
+      "Building", "Solar Plant", "City"
+      "Building", "Power Plant", "City"
+      "Building", "Hydro Plant", "City"
     }

[effect_offshore_platform]
@@ -1308,6 +1328,7 @@
       "Building", "Hoover Dam", "Player"
       "Building", "Nuclear Plant", "City"
       "Building", "Hydro Plant", "City"
+      "Building", "Solar Plant", "City"
     }

[effect_power_plant_1]
@@ -1324,6 +1345,7 @@
       "Building", "Hoover Dam", "Player"
       "Building", "Nuclear Plant", "City"
       "Building", "Hydro Plant", "City"
+      "Building", "Solar Plant", "City"
     }

[effect_recycling_center]
@@ -1333,6 +1355,10 @@
     { "type", "name", "range"
       "Building", "Recycling Center", "City"
     }
+nreqs  =
+    { "type", "name", "range"
+      "Building", "Solar Plant", "City"
+    }

[effect_research_lab]
name    = "Output_Bonus"
@@ -1402,8 +1428,8 @@
     { "type", "name", "range"
       "Building", "Hoover Dam", "Player"
       "Building", "Power Plant", "City"
-      "Building", "Hydro Plant", "City"
       "Building", "Nuclear Plant", "City"
+      "Building", "Hydro Plant", "City"
     }

[effect_solar_plant_1]
@@ -1425,7 +1451,7 @@

[effect_solar_plant_2]
name    = "Pollu_Prod_Pct"
-value  = -50
+value  = -100
reqs    =
     { "type", "name", "range"
       "Building", "Factory", "City"
@@ -1433,27 +1459,18 @@
     }
nreqs   =
     { "type", "name", "range"
-      "Building", "Recycling Center", "City"
-      "Building", "Hoover Dam", "Player"
-      "Building", "Nuclear Plant", "City"
-      "Building", "Hydro Plant", "City"
+      "Building", "Mfg. Plant", "City"
     }

[effect_solar_plant_3]
name    = "Pollu_Prod_Pct"
-value  = -50
+value  = -100
reqs    =
     { "type", "name", "range"
+      "Building", "Factory", "City"
       "Building", "Mfg. Plant", "City"
       "Building", "Solar Plant", "City"
     }
-nreqs  =
-    { "type", "name", "range"
-      "Building", "Recycling Center", "City"
-      "Building", "Hoover Dam", "Player"
-      "Building", "Nuclear Plant", "City"
-      "Building", "Hydro Plant", "City"
-    }

[effect_space_component]
name    = "SS_Component"
@@ -1725,6 +1742,7 @@
nreqs   =
     { "type", "name", "range"
       "Building", "Recycling Center", "City"
+      "Building", "Solar Plant", "City"
     }

[effect_hoover_dam_3]
@@ -1738,6 +1756,7 @@
nreqs   =
     { "type", "name", "range"
       "Building", "Recycling Center", "City"
+      "Building", "Solar Plant", "City"
     }

[effect_isaac_newtons_college]





_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to