<URL: http://bugs.freeciv.org/Ticket/Display.html?id=40531 >

2008/10/17 Madeline Book:
>> [chrisk - Fri Oct 17 10:06:57 2008]:
>> I switched to edit mode and set the terrain ownership,
>> in a reasonable way, as I think they should be.
>> After that I called "recalculate borders" which made civserver crash.
>> In another attempt, I didn't call "recalculate borders", and ended
>> edit mode. It crashed then at turn done.
> This is a known problem and I have left a FIXME (for myself :\) to
> that effect in handle_edit_territory. Right now all that function
> does is change the ownership of the tile to the given player via
> tile_set_owner. The problem is that the border system seems to rely
> on some extra data structures and auxillary functions that are
> entangled with vision sites and specific game rules. It is not clear
> how the editor can just "make one tile part of this player's
> territory" without producing some wierd inconsistencies in the
> latter (like a tile that remains unfogged even when no cities or
> units are nearby).
> Well, maybe I just need to better understand the current border
> system. I'll have a look as time permits.

 I don't think it's possible for editor to properly change tile owner.
In any case border code should recalculate situation each turn, so it
would restore situation to same as it was before manual editing.

 Border code / vision sites / everything else entangled is horrible
mess. I still don't understand how it is even *supposed* to work.
Rewrite from scratch is not necessarily bad idea, though 2.2 should be
released sooner rather than later.

 - ML

Freeciv-dev mailing list

Reply via email to