Follow-up Comment #1, bug #13848 (project freeciv):

Looks good in most part.

- I don't like "switch" and "case" at same indentation level. I would vote
for half indent step (2/2 = 1) for "case"
- Could you add assert() rule that instead of "assert(FALSE)" assert with
more verbose error message should be used when possible:

switch(value) {
 case 1:
 case 2:
 case 3:
   assert(value != 3);


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to