Follow-up Comment #2, bug #14415 (project freeciv):

> - for (; j < game.control.num_base_types + (4 -
> (game.control.num_base_types % 4)); j++) {
> + for (; j < game.control.num_base_types; j++) {
> base_order[j] = NULL;
> }

I cannot check source code for this now, but I'm quite sure that correct fix
would be to increase size of the base_order array.
I believe this loop iterates *only* over values game.control.num_base_types -
(4 - (game.control.num_base_types % 4)) so after your change it does nothing.
And - depending on savegame (if it's saved in older Freeciv version than
where loaded) - it's possible that those indexes of base_order array are
accessed later in the code.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?14415>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to