URL:
  <http://gna.org/bugs/?14505>

                 Summary: Fix many connection issues
                 Project: Freeciv
            Submitted by: pepeto
            Submitted on: lundi 12.10.2009 à 13:37
                Category: general
                Severity: 4 - Important
                Priority: 7 - High
                  Status: Ready For Test
             Assigned to: pepeto
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.2.0

    _______________________________________________________

Details:

I noticed many oddities in the connection handling, due to the crossed
changes of W. Simpson, Book and myself.  Some parts of the code were still
assuming that the detached state was invalid, whereas some others didn't. 
The delta code wasn't absolutely reset at the right places.

I couldn't make separated patches because all are linked to others.

So, this patch fix that:
* bug #14502: Remove some useless notifications (e.g. connections infos in
send_all_info()).
* bug #14499: Don't send the attribute block to observers.
* Added comment to know what packet is useful when connecting and what it is
not needed.
* Synchronized delta-state reset in both sides.
* Fixed potential crash in edithand due to the call of detach_command without
quotes.  (Look at rt PR#39130)
* "/take -" is not valid when the game isn't new.
* bug #14500: /detach makes the player's username (if controlled) to
anonymous.
* bug #14498: Displacing connections due to /take works as expected.
* Observe over a connected player isn't considered as global observing in
client side, this caused many errors due to the unknown terraon.
* When the ruleset is received at the client side, it doesn't do a full
game_free()/game_init().




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: lundi 12.10.2009 à 13:37  Name: trunk_S2_2_conn_handle_cleanup.diff 
Size: 22 ko   By: pepeto

<http://gna.org/bugs/download.php?file_id=6973>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?14505>

_______________________________________________
  Message posté via/par Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to