Summary: Cities not refreshed when crossing Empire_Size_Step
Submitted by: jtn
Submitted on: Tuesday 27/10/09 at 01:09
Severity: 3 - Normal
Priority: 5 - Normal
Assigned to: None
Discussion Lock: Any
Operating System: None
Planned Release: None
I originally raised this in RT as PR#40436. My original report:
> If, during a turn, conquering or founding a city causes the empire to
> grow and every city to get an extra unhappy citizen due to
> Empire_Size_Step, it appears that the client's cities are not refreshed
> immediately; the unhappiness shows up when performing subsequent actions
> on the city, such as moving workers around or changing specialists. So
> those actions can appear to increase unhappiness, which is confusing.
> Saving, quitting, and restoring the savegame causes all cities to be
> up-to-date. (I think hitting "turn done" may have this effect also, but
> I haven't checked.)
> I guess the server needs to send city updates to client(s) when an
> Empire_Size_Step boundary is crossed, or something like that -- I
> haven't investigated the code.
> Seen in 2.1.4 and 2.1.6 (and one previous version I can't remember).
> (I idly wonder whether a message when the unhappiness penalty grows
> might not be a bad idea. I was rather confused why my empire was
> suddenly in uproar after moving from 2.0.x to 2.1.x.)
I've raised it again here, as I have a patch (against trunk) which appears to
fix the issue for me (having first verified that it's still happening on the
trunk). I'm not 100% sure it's the correct patch, though.
(For instance: shouldn't this send an update to any player who can see the
subject player's cities, not just the subject player? I just copied what I
Date: Tuesday 27/10/09 at 01:09 Name: refresh-all-new-city-trunk.diff Size:
469B By: jtn
Refresh all cities when a new city is added, in case unhappiness increased
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list