Follow-up Comment #2, patch #1356 (project freeciv):

> Why did you add those useless prototypes?

I think every static function should be announced at the top of the *.c
file?

> You also should use secfile_lookup_str_int(). 

see comment to patch #1355

> Global headers like <assert.h> are usually included before
> freeciv ones like "support.h" (see in generate_specenum.h) 

will change this ...

> This comment looks superfluous to me... One can change that
> data without changing this comment... Anyway, if the this
> setting was too low, then the last enumerators wouldn't be
> declared and the compilation would fail. 

The comment should be included to give a hint there to search for the case of
the error. The current number could be removed.


    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?1356>

_______________________________________________
  Nachricht geschickt von/durch Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to