Summary: F_SUPERSPY attacker always wins
Submitted by: None
Submitted on: Tuesday 12/08/2009 at 13:29 CET
Severity: 3 - Normal
Priority: 5 - Normal
Assigned to: None
Originator Email: bernd.jendris...@gmail.com
Discussion Lock: Any
Operating System: None
Planned Release: None
diplomat_success_vs_defender() tests if the attacker has F_SUPERSPY before it
tests the defender. This is a change in behaviour since 2.1.9.
The comment in diplomat_infiltrate_tile() is self-contradictory:
/* A F_SUPERSPY unit may not actually be a spy, but a superboss
* which we cannot allow puny diplomats from getting the better
* of. Note that diplomat_success_vs_defender() is always TRUE
* if the attacker is F_SUPERSPY. Hence F_SUPERSPY vs F_SUPERSPY
* in a diplomatic contest always kills the attacker. */
While the first part is (now) true, the second is now false.
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list