URL:
<http://gna.org/bugs/?15612>
Summary: Missing lua_pop call in script_callback_invoke
Project: Freeciv
Submitted by: englabenny
Submitted on: söndag 2010-03-14 den 01:58
Category: None
Severity: 3 - Normal
Priority: 1 - Later
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:
_______________________________________________________
Details:
When the callback returned true, we did not call lua_pop(..).
lua_toobolean does not pop off the stack, so we left a value there in
this case.
This error was hard to diagnose since we got no explicit error, but
inconsistent return values from callbacks (not always true even if script
said 'return true'). With this fix, return values are consistent.
A Patch against 2.2 is attached.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: söndag 2010-03-14 den 01:58 Name:
0001-Always-remove-return-values-from-stack-in-script_cal.patch Size: 1 kB
By: englabenny
<http://gna.org/bugs/download.php?file_id=8517>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?15612>
_______________________________________________
Meddelandet skickades via/av Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
