Summary: Lack of generality for specialists in city report /
citizen governor display
Submitted by: jtn
Submitted on: Saturday 03/27/10 at 13:37
Severity: 2 - Minor
Priority: 5 - Normal
Status: Ready For Test
Assigned to: jtn
Discussion Lock: Any
Operating System: None
Planned Release: 2.3.0
While the number and type of specialists is nominally set by the ruleset,
there are still a couple of places where the assumption that there are
exactly three types, E/S/T, is hardcoded:
* In the city report, there's a column "E/S/T" = "Entertainers, Scientists,
Taxmen" (although the column actually displays the ruleset specialist types,
and there are individual columns for the ruleset-defined specialist types).
* In the citizen governor, there's a heading "People (W/E/S/T):" (again, the
actual specialists are displayed even if different in number).
The attached patch addresses this. Side-effects:
* The explanation of the combined specialists column changes from
"Entertainers, Scientists, Taxmen" to "Specialists: elvis, scientist,
taxman", which is a bit ugly.
** This could be fixed by defining a plural name in rulesets, and probably
decoupling the rule name ("elvis") from the display name ("Entertainer"). I
haven't done this.
* The initial position of the combined specialists column moves left.
The issue applies to S2_1, S2_2, and trunk, but the patch touches strings
hence only patched for trunk.
Date: Saturday 03/27/10 at 13:37 Name: trunk-specialist-generality.diff
Size: 6kB By: jtn
trunk r17166: generalise specialists in city report and citizen governor
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list