URL:
  <http://gna.org/bugs/?15734>

                 Summary: EFT_MIGRATION_PCT quantised to multiples of 100%
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Sunday 03/28/10 at 21:42
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: Ready For Test
             Assigned to: jtn
        Originator Email: 
             Open/Closed: Open
                 Release: 2.2.0
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.2.1

    _______________________________________________________

Details:

Looking at city_migration_score():


score *= (1.0 + get_city_bonus(pcity, EFT_MIGRATION_PCT) / 100);


Since get_city_bonus() returns an int, the division will be done in integer
arithmetic (and then converted to float for addition to 1.0). This means the
sum of EFT_MIGRATION_PCT can't usefully take values other than 0 (normal
score), 100 (double score), -100 (zero score regardless of anything), and so
on. This doesn't seem very useful.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sunday 03/28/10 at 21:42  Name: S2_2-trunk-migration-eft-float.diff 
Size: 445B   By: jtn
S2_2/trunk r17182: fix Migration_Pct effect
<http://gna.org/bugs/download.php?file_id=8715>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?15734>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to