URL:
<http://gna.org/bugs/?15983>
Summary: incomplete rename of my_nonblock
Project: Freeciv
Submitted by: jkl
Submitted on: Sunday 05/02/2010 at 16:11
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:
_______________________________________________________
Details:
Back in 2008, a bunch of nework functions with a "my_" prefix were renamed
using an "fc_" prefix. One of those is the my_nonblock function in
utility/netintf.c.
Unfortunately, not all references were changed. There are still two
references to my_nonblock in utility/support.c (one in code, one in a
comment). Attached is a patch.
How could this have gone undetected for around 18 months? Because the
reference in question is inside a nest of #ifdef blocks. In particular,
apparently there is system for which:
SOCKET_ZERO_ISNT_STDIN is defined
WIN32_NATIVE is not defined
HAVE_FILENO is defined
Does anyone know what system this is?
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Sunday 05/02/2010 at 16:11 Name: rename-my_nonblock.patch Size: 878B
By: jkl
<http://gna.org/bugs/download.php?file_id=9108>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?15983>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
