Summary: Make unit_info_label fixed-size as intended
                 Project: Freeciv
            Submitted by: jon_severinsson
            Submitted on: måndag 2010-05-31 den 23:42
                Category: client
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 



This is the first patch in a short series intended to improve the gtk gui on
netbook sized displays.

Looking at the comments for get_unit_info_label_text2 in client/text.c it is
obvious that the returned sting is supposed to always contain exactly 4
lines, so that the unit info label doesn't resize itself.

However, when multiple units are selected it will instead contain exactly 5
lines, whether the extra line is necessary or not, and thus force a resize of
the label.

This patch removes the extra line. In most cases it will only remove a blank
line. However, if 4 or more different types of units are selected the unit
info box would previously include the amount of the 3 most common types and a
summary of the rest, while with the patch it will only list the 2 most common
types and a summary of the rest.


File Attachments:

Date: måndag 2010-05-31 den 23:42  Name:
freeciv-2.2.1-fix-unit-info-label-fixed-size.patch  Size: 1001 B   By:



Reply to this item at:


  Meddelandet skickades via/av Gna!

Freeciv-dev mailing list

Reply via email to