Summary: [trunk] PostModern city style always used
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Sunday 07/04/10 at 02:01
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: trunk r17524
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.3.0



Noticed with recent trunk (r17524), don't know how far back it goes:

All cities of all players are being drawn in the PostModern style regardless
of technology. Happens when loading an existing savegame (which works fine in
S2_2) or starting a new game.

Haven't fully tracked it down, but I think the problem is in the server (at
least). package_player_common() calls city_style_of_player(), which starts
with (struct player).city_style (which appears to be correct --
European/Celtic/etc), but then when it goes through the are_reqs_active()
loop, it apparently decides the requirements are always active and so ends up
at PostModern.

I think this is then sent as packet_player_info.city_style to the client,
which when it runs city_style_of_player() starts (and hence ends) at
PostModern. (Aside: the client's going through the requirements loop in
city_style_of_player() doesn't seem very useful, although it's probably
harmless; seems like it should just use what the server told it.)

I haven't spotted what's different here to the (working) S2_2 code (same svn
rev), although I haven't looked that hard yet.


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to