Summary: Global warming & nuclear winter may change a tile
multiple times
                 Project: Freeciv
            Submitted by: handuman
            Submitted on: Thursday 08/12/10 at 16:24
                Category: general
                Severity: 2 - Minor
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 2.2.2
         Discussion Lock: Any
        Operating System: None
         Planned Release: 



This is not a problem with default ruleset but a custom ruleset may have
sequental definitions for warmer_wetter_result (as well the three other
_results). The randomly chosen tile in 
void global_warming(int effect) and
void nuclear_winter(int effect) (in maphand.c)
might hit one tile several times during one disaster resulting in unexpected
change of terrain.

For example, with following definitions
warmer_wetter_result = "terrain_swamp"
warmer_wetter_result = "terrain_ocean"

a plains tile might collapse into ocean in just one occurrence of global

Also, the code seems to have been written assuming that the random tile
picker never hits twice on the same tile since the iteration is stopped after
{total number of tiles on the map} times.


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to