Update of patch #1975 (project freeciv):
Status: None => In Progress
Planned Release: => 2.3.0
_______________________________________________________
Follow-up Comment #1:
When I read the content of this item, I was afraid it wouldn't be
configurable. As it is done by an option, this patch is good.
However:
* There are tabs, they should be replaced by spaces (newly code).
* Passing F_NOHOME is not right here because it's a unit type flag, and not a
city id. It should be IDENTITY_NUMBER_ZERO, according to
create_unit_virtual(). Note that it's not the only place IDENTITY_NUMBER_ZERO
is missing to test unit::homecity. Probably it could be replaced by a pointer
anyway.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1975>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
