Follow-up Comment #4, patch #2019 (project freeciv):

You are sharing static datas in the files that are not needed. A good design
would be to only use one only reference (probably in mapimg_dialog_popup())
to a GtkWidget. mapimg_dialog_new() should return the created GtkWidget, not
sharing static datas.

Also, all *_mapimg_dialog() functions doesn't match Freeciv coding style,
they should be named mapimg_dialog_*().


Reply to this item at:


  Message posté via/par Gna!

Freeciv-dev mailing list

Reply via email to