Follow-up Comment #4, bug #16887 (project freeciv):

> Why returning as a read-or-write data?

Done; see below

> Please at least add comment to "if (tok[0] != '/')" that "/"
> is not root directory in some environments. (In windows
> absolute path would start with letter as in "C:")

Done; see below

> Also check that we don't already define such a string as a
> macro somewhere. IIRC we have PATH_SEPARATOR at least ('/'
> or '\') which you fail to use in this patch btw.

PATH_SEPARATOR is the separator between different paths, i.e. ";" (windows)
or ":" (linux)

updated patch:

* current_dir(), user_home_dir() and user_username() return const data
* the check is only defined for *nix systems


(file #10828)
    _______________________________________________________

Additional Item Attachment:

File name:
20101019-trunk-generate-a-full-path-from-a-given-relative-path.patch Size:6
KB


    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?16887>

_______________________________________________
  Nachricht geschickt von/durch Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to