Follow-up Comment #4, bug #17264 (project freeciv):

Since MAX_VET_LEVELS is hardcoded at 10 what is the point of doing this
calculation 20/MAX_VET_LEVELS is always 2.

Also why bother with the +1
chance += 2 * (pattacker->veteran + 1)

You add 2 for a green diplomat attacker only to subtract 2 for a green
diplomat defender immediately afterwards.

It would be better to write
chance += 2 * (pattacker->veteran)

We are now back to the original code except 15 has been replaced by 2. The
problem here is that the value for an elite diplomat fighting a green diplomat
is too low. 56% does not give the correct advantage. An elite should be twice
as powerful hence 66% is more appropriate. 


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to