URL:
  <http://gna.org/bugs/?17718>

                 Summary: Mapcanvas not freed
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sun 13 Feb 2011 01:02:05 AM EET
                Category: client
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: Ready For Test
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.3.0, 2.4.0

    _______________________________________________________

Details:

As valgrind puts it:

==13818== 1,290,240 bytes in 1 blocks are still reachable in loss record 667
of 680
==13818==    at 0x4C244E8: malloc (vg_replace_malloc.c:236)
==13818==    by 0x7E92F35: SDL_CreateRGBSurface (in
/usr/lib/libSDL-1.2.so.0.11.3)
==13818==    by 0x495339: create_surf_with_format (graphics.c:333)
==13818==    by 0x46AB5A: canvas_create (canvas.c:47)
==13818==    by 0x42A511: map_canvas_resized (mapview_common.c:2921)
==13818==    by 0x407FC5: overview_size_changed (mapview.c:367)
==13818==    by 0x42D0BE: calculate_overview_dimensions
(overview_common.c:464)
==13818==    by 0x4338B4: handle_map_info (packhand.c:1592)
==13818==    by 0x435DE1: client_handle_packet (packhand_gen.c:63)
==13818==    by 0x40C09D: client_packet_input (client_main.c:566)
==13818==    by 0x411384: input_from_server (clinet.c:417)
==13818==    by 0x405E03: gui_event_loop (gui_main.c:694)
==13818==    by 0x406211: ui_main (gui_main.c:1057)
==13818==    by 0x40C529: client_main (client_main.c:509)
==13818==    by 0x83C4C4C: (below main) (libc-start.c:228)

and similar report for creation of _tmp canvas.

Attached patches should fix this. Difference between TRUNK and S2_3 versions
is that in TRUNK version also Qt-client is fixed (S2_3 fixes gtk, sdl and xaw
clients).



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 13 Feb 2011 01:02:05 AM EET  Name: FreeMapcanvas.diff  Size: 3kB  
By: cazfi

<http://gna.org/bugs/download.php?file_id=12417>
-------------------------------------------------------
Date: Sun 13 Feb 2011 01:02:05 AM EET  Name: FreeMapcanvas-S2_3.diff  Size:
3kB   By: cazfi

<http://gna.org/bugs/download.php?file_id=12418>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?17718>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to