Update of bug #18133 (project freeciv):

                  Status:               Need Info => Ready For Test         
             Assigned to:                    None => jtn                    
         Planned Release:                         => 2.3.0                  
                 Summary: civ2: Fundamentalism has no Empire_Size_Step =>
civ2/multiplayer: Fundamentalism has no Empire_Size_Base/Step


Follow-up Comment #2:

Oops, it's worse than that -- there's no EMPIRE_SIZE_BASE either.

Right now, the absence of both effects means that the whole empire size
penalty is disabled (see special case in player_content_citizens()), so every
city under Fundamentalism has EFT_CITY_UNHAPPY_SIZE=4 content citizens
regardless of empire size.

(Also, the happiness breakdown in text_happiness_cities() doesn't know about
this special case, so gives incorrect information in this case. README.effects
is out of date here too. Raised separately as bug #18150.)

Pre PR#15396 <http://bugs.freeciv.org/Ticket/Display.html?id=15396>,
Fundamentalism would have had the default cityfactor+MOD of 14 (but no STEP
after that). (The effective BASE values for civ2 Anarchy/Despotism changed in
this version, but other govs remained the same.)

So, to revert these apparently unintended changes, we'd need
EMPIRE_SIZE_BASE=14 and EMPIRE_SIZE_STEP=12. The attached patch does this (for
civ2 and multiplayer rulesets).

(file #13021)

Additional Item Attachment:

File name: trunk-S2_3-empire-size-fundamentalism.diff Size:1 KB


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to