URL:
<http://gna.org/bugs/?18211>
Summary: try_to_connect() may return success on failure
Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 14 Jun 2011 03:12:51 AM EEST
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
Status: Ready For Test
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release: 2.2.6, 2.3.0, 2.4.0
_______________________________________________________
Details:
In case of network problem two_to_connect() returns errno on platforms other
than Windows. But there are some system calls between the failure and
accessing errno, so it's already overwritten by the time it's accessed. In
practice this means that try_to_connect() returns success even in case of
network problems.
Fix attached
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Tue 14 Jun 2011 03:12:51 AM EEST Name:
TryToConnectErrnoReturn-S2_2.diff Size: 601B By: cazfi
<http://gna.org/bugs/download.php?file_id=13191>
-------------------------------------------------------
Date: Tue 14 Jun 2011 03:12:51 AM EEST Name: TryToConnectErrnoReturn.diff
Size: 677B By: cazfi
<http://gna.org/bugs/download.php?file_id=13192>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?18211>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
