Submitted by: cazfi
Submitted on: Fri 24 Jun 2011 12:49:59 AM EEST
Priority: 5 - Normal
Status: Ready For Test
Assigned to: None
Discussion Lock: Any
Planned Release: 2.4.0
Now that availability of getaddrinfo() is hard requirement for IPv6 support,
it doesn't make sense that IPv6-enabled freeciv uses it only for IPv6
addresses and handles IPv4 addresses with all kinds of legacy code.
Attached patch changes net_lookup_service() so that IPv6-enabled version uses
getaddrinfo() for both IPv6 and IPv4 addresses and legacy code is used only by
IPv4-only freeciv. This might even drop some dependencies to legacy
(=basically deprecated) system calls from IPv6-enabled freeciv, but I have not
actively investigated if that's really the case.
Next logical step will be to make also IPv4-only freeciv to use getaddrinfo()
when available, but that's stuff for another ticket.
I started to hack together networking related patch which I expect to be
commit quality only after S2_4 branching -> stuff for 2.5. But when doing it,
I've found a lot of things to be fixed in networking code in 2.4 (at latest,
it may make sense to port something to 2.3 already). You can expect more
networking code patches in near future.
Date: Fri 24 Jun 2011 12:49:59 AM EEST Name: NetLookupAddrinfo.diff Size:
4kB By: cazfi
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list