Summary: Area selection: code exists for appending rectangle
to existing selection, but it's unreachable
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Sat Jul  2 22:08:51 2011
                Category: client-gtk-2.0
                Severity: 2 - Minor
                Priority: 5 - Normal
                  Status: In Progress
             Assigned to: jtn
        Originator Email: 
             Open/Closed: Open
                 Release: 2.2.5,2.3.0-beta4
         Discussion Lock: Any
        Operating System: Any
         Planned Release: 2.3.0,2.4.0



The "area selection" mode in the Gtk client (right-click-drag) allows a set
of units/cities to be selected.

There's also a 'rectangle_append' variable, initialised from whether Shift is
held down at the time the drag is initiated. This is clearly intended to allow
Shift-right-click-drag to add to the existing selection. However, it's
currently unreachable, because Shift-right-click means "copy thing under
cursor to production clipboard".

After the attached patch:
* The clipboard action is only checked if something suitable is under the
cursor, so a Shift-right-drag rectangle selection can now be initiated from an
empty tile.
* The Shift key is only registered at button-up, not button-down. This allows
the user to change their mind about whether they want to append after starting
the action.
* City highlighting now honours the "append" mode, like unit selection.


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to