Follow-up Comment #1, patch #2947 (project freeciv):

updated spec file; changes:

- split freeciv-tools in freeciv-manual and freeciv-modpack
- name space cleanup (dependency were named after non-existend packages)
- longer description (use freeciv header)

the following rpm lint errors are still present.


RPMLINT report:
 ===============
 freeciv-aimodules-devel.x86_64: W: static-library-without-debuginfo
/usr/lib64/fcai/fc_ai_stub.a
 freeciv-aimodules-devel.x86_64: W: static-library-without-debuginfo
/usr/lib64/fcai/fc_ai_threaded.a
 libfreeciv0-devel.x86_64: W: static-library-without-debuginfo
/usr/lib64/libfreeciv.a
 The static library doesn't contain any debuginfo. Binaries linking against
 this static library can't be properly debugged.
 
 libfreeciv-srv0.x86_64: W: shared-lib-calls-exit
/usr/lib64/libfreeciv-srv.so.0.0.0 exit@GLIBC_2.2.5
 libfreeciv-srv0.x86_64: W: shared-lib-calls-exit
/usr/lib64/libfreeciv-srv.so.0.0.0 exit@@GLIBC_2.2.5
 libfreeciv0.x86_64: W: shared-lib-calls-exit /usr/lib64/libfreeciv.so.0.0.0
exit@GLIBC_2.2.5
 libfreeciv0.x86_64: W: shared-lib-calls-exit /usr/lib64/libfreeciv.so.0.0.0
exit@@GLIBC_2.2.5
 This library package calls exit() or _exit(), probably in a non-fork()
 context. Doing so from a library is strongly discouraged - when a library
 function calls exit(), it prevents the calling program from handling the
 error, reporting it to the user, closing files properly, and cleaning up
any
 state that the program has. It is preferred for the library to return an
 actual error code and let the calling program decide how to handle the
 situation.
 
 freeciv-client-gtk3.x86_64: W: no-manual-page-for-binary freeciv-gtk2x
 freeciv-manual.x86_64: W: no-manual-page-for-binary freeciv-manual
 Each executable in standard binary directories should have a man page.
 
 freeciv-client-sdl.x86_64: W: generic-name-not-in-filelist
/usr/bin/freeciv-client
 freeciv-client-xaw.x86_64: W: generic-name-not-in-filelist
/usr/bin/freeciv-client
 freeciv-client-gtk2.x86_64: W: generic-name-not-in-filelist
/usr/bin/freeciv-client
 The generic name is not in a filelist of package, add it to list marked as
 %ghost. Note: this error will be raised, if you use a hash ($) in file
name,
 use rpm macros in spec file instead.
 
 libfreeciv-srv0.x86_64: W: devel-file-in-non-devel-package (Badness: 50)
/usr/lib64/libfreeciv-srv.so
 libfreeciv0.x86_64: W: devel-file-in-non-devel-package (Badness: 50)
/usr/lib64/libfreeciv.so
 A development file (usually source code) is located in a non-devel package.
If
 you want to include source code in your package, be sure to create a
 development package.
 
 20 packages and 0 specfiles checked; 0 errors, 14 warnings.


While most of the errors are rpm spezific, the one about the calls to exit()
should be fixed in the freeciv source (if possible).

(file #14007)
    _______________________________________________________

Additional Item Attachment:

File name: freeciv.spec                   Size:24 KB


    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?2947>

_______________________________________________
  Nachricht geschickt von/durch Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to