URL:
<http://gna.org/bugs/?19518>
Summary: Nationality related crash when city size reduces by
multiple citizens
Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 01 Mar 2012 09:25:22 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: Ready For Test
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release: 2.4.0, 2.5.0
_______________________________________________________
Details:
This crash can happen if city size reduces by more citizens than one of the
nationalities in the city has, and one gets unlucky with random number
generator.
When one nationality disappears completely, player slot copy has off-by-one
error possibly causing garbage slot to be added to array of remaining
nationalities. If attempt to remove more citizens hits that slot, server
crashes.
Fix attached
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Thu 01 Mar 2012 09:25:22 PM EET Name: NationalityRemovalOffByOne.diff
Size: 536B By: cazfi
<http://gna.org/bugs/download.php?file_id=15310>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?19518>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
