URL:
  <http://gna.org/bugs/?19627>

                 Summary: Borders updated while player removal state
inconsistent
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sun 08 Apr 2012 09:16:33 PM EEST
                Category: general
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: Ready For Test
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.3.3, 2.4.0, 2.5.0

    _______________________________________________________

Details:

When player is being removed, borders are recalculated before player is
completely removed but after playermap of the player to be removed has been
freed. With already committed fix to bug #18588 this causes assert failures as
border update wants to update player map of player to be removed.
I'm not entirely sure if update of borders this early was causing problems
(i.e., if it was bug) even before bug #18588 fix making it more obvious.
Attached patch moves borders recalculate after there are only those players
that remain after one being removed is really removed.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 08 Apr 2012 09:16:33 PM EEST  Name:
AvoidInconsistStateBorderRecalc.diff  Size: 938B   By: cazfi

<http://gna.org/bugs/download.php?file_id=15537>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?19627>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to