Summary: effect name -> type
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Thu 19 Apr 2012 03:23:22 AM EEST
                Category: general
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.5.0



When effects were first introduced I found "name" field very confusing, and I
think it might still be that to newbies. At least it's inconsistent with other
ruleset objects. In every place other "name" identifies that particular
instance, and it usually must be unique. Effect name however refers to what
kind of effect it is and there's many effects with same name with a bit
different requirements.

Attached patch is step to rename that field as "type". Ruleset loading loads
the field as either "name" or "type", with "type" taking precedence if both
are present. This patch does not touch any of the rulesets. They rely on the
backward compatibility feature that "name" still works as fallback to "type".


File Attachments:

Date: Thu 19 Apr 2012 03:23:22 AM EEST  Name: EffectType.diff  Size: 731B  
By: cazfi



Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to