URL:
<http://gna.org/patch/?3344>
Summary: correct slight inaccuracy in GdkColor computation
Project: Freeciv
Submitted by: None
Submitted on: Tue 26 Jun 2012 03:59:32 PM UTC
Category: client-gtk-3.0
Priority: 3 - Low
Status: None
Privacy: Public
Assigned to: None
Originator Email: galtge...@o2.pl
Open/Closed: Open
Discussion Lock: Any
Planned Release:
_______________________________________________________
Details:
OK, this will be pure nitpicking (as with rounding the result is likely
(almost) the same), but if we're going from 8bit per component to 16bit per
component, the correct integer formula would be '16bit value = (8bit value <<
8) + 8bit value'.
While the patch is against gtk3 client, similar fix could be done for gtk2
client.
But on this note: surface_get_pixbuf is only correct if alpha is 0.0 or 1.0,
otherwise we're running into premultiplied alpha problem.
It seems to not be a problem for the current graphic sets (it seems they're
only using those values), but should I submit the patch fixing the problem ?
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Tue 26 Jun 2012 03:59:32 PM UTC Name: nitpick-colors.patch Size: 481B
By: None
nitpick at GdkColor
<http://gna.org/patch/download.php?file_id=15895>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3344>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
