Summary: Sort out 'check' behaviour for playercolor/mapimg
Submitted by: jtn
Submitted on: Sun Jul 1 11:35:03 2012
Severity: 2 - Minor
Priority: 5 - Normal
Status: In Progress
Assigned to: jtn
Discussion Lock: Any
Operating System: Any
Planned Release: 2.4.0,2.5.0
Somehow I got it into my head that server commands should be silent when the
'check' argument is specified. Now I remind myself what it's for -- it's used
when deciding whether a vote is worth starting -- that's actually
counterproductive; it's useful to tell the person who submitted the command
why it didn't get even as far as a vote.
So far I've perpetrated this misapprehension on 'playercolor'. While reviewing
for other cases I found 'mapimg' had some bugs in the 'check' case; I dunno
whether I introduced them, but I may as well fix them.
In these cases it's academic, as these are currently ALLOW_ADMIN commands and
voting is only triggered on ALLOW_CTRL commands. So this fix is more about
future-proofing and not leaving incorrect patterns to propagate.
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list