Update of patch #3367 (project freeciv):

         Planned Release:                         => 2.5.0                  

    _______________________________________________________

Follow-up Comment #1:

Thank you. Seems like big step forward for Qt-client.

- Please read doc/CodingStyle. Though it's not yet updated to reflect the fact
that Qt-client is C++, and not C, most of it still valid ( "if (" and not
"if(", block required even for single command after if... )

- Compiling with --enable-debug -> -Werror:

../../../../src/client/gui-qt/mapview.cpp: In function 'void
pixmap_put_overlay_tile(int, int, sprite*)':
../../../../src/client/gui-qt/mapview.cpp:224:6: error: no previous
declaration for 'void pixmap_put_overlay_tile(int, int, sprite*)'
[-Werror=missing-declarations]

../../../../src/client/gui-qt/optiondlg.cpp:38:35: error: 'option_dialogs'
defined but not used [-Werror=unused-variable]
../../../../src/client/gui-qt/optiondlg.cpp:99:13: error: 'void
option_dialog_option_apply(option*)' defined but not used
[-Werror=unused-function]

../../../../src/client/gui-qt/pages.cpp: In function 'void
create_conn_menu(player*, connection*)':
../../../../src/client/gui-qt/pages.cpp:336:6: error: no previous declaration
for 'void create_conn_menu(player*, connection*)'
[-Werror=missing-declarations]
../../../../src/client/gui-qt/pages.cpp: In function 'void
server_scan_error(server_scan*, const char*)':
../../../../src/client/gui-qt/pages.cpp:598:6: error: no previous declaration
for 'void server_scan_error(server_scan*, const char*)'
[-Werror=missing-declarations]




    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?3367>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to