Summary: Remove make rules for object files to depend on
built headers
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sat 07 Jul 2012 11:51:24 PM EEST
                Category: bootstrap
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.5.0



There are make dependencies for built headers in common/ and utility/ meant to
assure that headers are built before they are included to any source file.

When one does full build, headers are built first in any case. Those rules
would be needed in a very unusual case that one wants to build only some
specific object file in a clean tree. I don't see anyone ever doing that so
the dependency is not very important - in any case you can build header
yourself before the object file:
> make packets_gen.h
> make base.o
Also, from what I've tested this, it's not working correctly anyway.

This rule is bad because it depends on GNU make extension. AFAICT those rules
are the only reason we're not POSIX make compliant.

Attached patch removes those rules.


File Attachments:

Date: Sat 07 Jul 2012 11:51:24 PM EEST  Name: BuiltSourceDepRm.patch  Size:
1kB   By: cazfi



Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to