URL:
  <http://gna.org/bugs/?19943>

                 Summary: Initial protocol between trunk and S2_4-or-earlier
broken?
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Sun Jul 15 11:50:02 2012
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: trunk r21550
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.5.0

    _______________________________________________________

Details:

The behaviour when a new (trunk r21550, "2.5") server/client talks to an older
(S2_4 or earlier) counterpart seems different, and less useful, to how this
situation was handled in the past. I haven't looked into it much. Perhaps one
of the aspects of the protocol that should never change, has?

Here's the behaviour I see:

trunk client, S2_4 server: server says:

1: Receiving packet_processing_started at the server.
2: Warning: rejecting old client c1 from localhost (connection incomplete)
2: Lost connection: c1 from localhost (rejected).


client says:

1: Lost connection to server: decoding error.


S2_4 client, trunk server: server says:

2: Connection request from tn from localhost
2: c1 has client version 2.3.99-alpha
2: Client rejected: c1 from localhost (connection incomplete).
2: tn was rejected: Mismatched capabilities.
2: Lost connection: c1 from localhost (rejected).


(Interesting -- my username is "jtn", not "tn".)

client says:

1: in handle_processing_started() [packhand.c::3408]: assertion
'client.conn.client.request_id_of_currently_handled_packet == 0' failed.
1: in handle_processing_started() [packhand.c::3408]: assertion
'client.conn.client.request_id_of_currently_handled_packet == 0' failed.
1: in handle_processing_started() [packhand.c::3408]: assertion
'client.conn.client.request_id_of_currently_handled_packet == 0' failed.
1: Lost connection to server: server disconnected.


Here's what I expect to happen: S2_3 client to S2_4 server: server says:

2: Connection request from jtn from localhost
2: c1 has client version 2.3.2+
2: Client rejected: c1 from localhost (connection incomplete).
2: jtn was rejected: Mismatched capabilities.
2: Lost connection: c1 from localhost (rejected).


and client says:

You were rejected from the game: The client is missing a capability that this
server needs.
Server version: 2.3.99-alpha Client version: 2.3.2+.  Upgrading may help!
Client capability string: +Freeciv-2.3-network timeout_extended_range
eg_report_size rules_finished
Server capability string: +Freeciv-2.4-network rules_finished
Lost connection to server (server disconnected)!





    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?19943>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to