Summary: universal_rule_name() returning weird strings
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Fri 27 Jul 2012 04:11:49 AM EEST
                Category: general
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: Ready For Test
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.5.0



universal_rule_name() returns wrong kind of strings for some types. Current
callers are interested only about units and buildings, which work ok, so
there's no user visible problems at the moment. (But I'm working on tool that
needs to get these right)

- Even though this is rule name some strings are collected for translation.
- Minsize returns format string ("%d") and it has extra explanatory word in it
compared to what is *rule* name in ruleset (in ruleset "type" is separate
- CityTile and Minyear return "(none)" instead of name

Fix attached. For dynamically constructed MinSize and MinYear types static
buffer is used.


File Attachments:

Date: Fri 27 Jul 2012 04:11:49 AM EEST  Name: URuleName.patch  Size: 2kB   By:



Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to