Summary: Hardcoded "Will be built as a veteran under
communist governments" for Diplomat/Spy
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Fri Aug  3 23:13:13 2012
                Category: docs
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: In Progress
             Assigned to: jtn
        Originator Email: 
             Open/Closed: Open
                 Release: 2.3.2
         Discussion Lock: Any
        Operating System: Any
         Planned Release: 2.3.3,2.4.0,2.5.0



The assertion "Will be built as a veteran under communist governments" is
hardcoded for diplomatic units in the help code, and will be emitted even if
it's not true.

The automatic government help for Communism does acknowledge this with
"Veteran Diplomat units" (here "Diplomat" is actually a unit flag, so it's
ambiguous whether this really means just Diplomats or Diplomats and Spies --
the latter is true).

The automatic unit help doesn't say anything -- describing the circumstances
in which a unit can become veteran is beyond the help system's current
capabilities. So I'll add some handwritten sentences about this to unit
descriptions in relevant rulesets.

(There are other bits of bad hardcoded text around veterancy, but this one is
particularly egregious, and easy to fix.)


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to