Summary: Client does not set correct transported_by info
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Mon 20 Aug 2012 03:23:03 AM EEST
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: None
         Planned Release: 



When client initially receives units (either when connecting to server or when
it suddenly sees allied units etc) that are transported, transported_by is not
set correctly.

It's set when unpackaging unit, but then...
packhand.c:1598: unit_transport_unload()
-> Unload from potential old transport. This sets transported_by to -1
packhand.c:1599: unit_transport_load()
-> This loads to correct transport, but it doesn't set transported_by

I'm not yet entirely sure if it's bug that unit_transport_unload() sets
transported_by, or is the bug that unit_transport_load() does not. Should
transported_by in the client be set only by network packet unpackaging, or
should those auxiliary functions also do what their name suggest?


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to