Update of bug #19852 (project freeciv):

                Category:                    None => general                
                  Status:                    None => Ready For Test         
         Planned Release:                         => 2.3.3, 2.4.0, 2.5.0    


Follow-up Comment #2:

That scripting expects nil return value from give_technology() if player
already has it. That's what our external documentation say.
However function header says that it returns pointer to A_NONE. That's
beginning of the techs array, not NULL. Implementation is according to that
function header.

I just decided that from the conflicting documentation the interpretation that
it should return NULL is correct, and current implementation is a bug.
Attached patch changes it to return NULL. It's rather unlikely that any script
out there could depend on old behavior.

(file #16655, file #16656)

Additional Item Attachment:

File name: DarwinFix.patch                Size:0 KB
File name: DarwinFix-S2_3.patch           Size:0 KB


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to