Follow-up Comment #7, patch #2829 (project freeciv):

So it's about a year too late to comment on this (sorry), but:

> Notable conceptual change here would be that data files would
> be built.
I have to say that I'm a little uneasy with that as a solution to the
line-ending problem -- it feels like a sledgehammer to crack a nut.
It'll be a bit of additional inconvenience during development (as already
acknowledged in comment #4) -- nothing insurmountable if the dependencies are
accurate, but the benefit doesn't obviously outweigh the cost, especially as
for data files Freeciv is already line-ending-agnostic as of patch #2843.
(That doesn't catch READMEs etc, which I think it'll be more common for users
to try to open, but Freeciv doesn't try and read those anyway.)

It feels to me like this (and similar things like compression) would perhaps
better be part of "make install" rather than "make".
That does mean that the typical developer experience (running from source
directory) diverges further from the "mission mode" (install and run), perhaps
increasing the possibility of install-only bugs not spotted until too late.

The arguments change if we're doing more stuff as part of "building" text
files, such as automatic substitutions.


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to