Summary: Merge update_rect_at_mouse_pos into move_mapcanvas
(patch 11/60)
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sun 21 Oct 2012 02:08:41 AM EEST
                Category: client-gtk-3.0
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 



This ticket is about handling patch 11/60 (merge update_rect_at_mouse_pos into
move_mapcanvas) from Rafał Mużyło's patchset in patch #3469

The patch inlines contents of update_rect_at_mouse_pos() to move_mapcanvas()
leaving former function empty. This results in simpler implementation.

I have not investigated issue very deeply, but update_rect_at_mouse_pos() is
part of gui API towards client common code, and it is in fact called from
there too. Leaving that function empty, i.e., it not doing what API promises,
seems wrong. Or can wew be sure that in case of gtk3 its (API defined)
implementation would be always redundant?


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to