URL:
  <http://gna.org/bugs/?20301>

                 Summary: Not all lost units counted in score.units_lost
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sat 17 Nov 2012 04:30:21 AM EET
                Category: general
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.3.3, 2.4.0, 2.5.0

    _______________________________________________________

Details:

bug #19821 point 4 is about units lost with their transport not being counted
in score.units_lost or score.units_killed. That's not the only place where
those counters are not properly increased. This ticket is about fixing all
cases.

Patch for S2_3 attached.
As S2_3 has no unit_loss_reason, patch for it is quite different from what
S2_4/TRUNK one will likely be.

This fixes following cases where units_lost was not increased though it
should:
- Units lost with their transport
- Units killed by hut barbarians
- Units killed by terrain changes
- Diplomats killed in fight against other diplomats
- Diplomats failing their mission (diplomats dying after succesfull mission
are not counted any more than are settlers founding cities or caravans
establishing traderoutes counted; they just perform their function)
- Units wiped from opponent terrain when entering peace

I consider inspection period of this S2_3 patch to begin now even though
S2_4/TRUNK patches are still missing (I may commit to S2_3 before other
branches)



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 17 Nov 2012 04:30:21 AM EET  Name: UnitsLostScore-S2_3.patch  Size:
18kB   By: cazfi

<http://gna.org/bugs/download.php?file_id=16770>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?20301>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to