Follow-up Comment #4, bug #18084 (project freeciv): Certainly patch #3346 addresses most of the concerns here (for 2.4.x onwards): * When --ranklog is used, score determines winner in the absence of a victory condition. * The text declaring the game a draw in this case is gone.
However, issues remain in this area: * The online help needs updating, but I'm uncomfortable doing that until the following is addressed: * The winning condition logic is somewhat duplicated currently between check_for_game_over() and rank_users(), and most of the latter isn't even run unless a ranklog file is requested. For instance, the only place the new highest-score-wins logic exists is in rank_users(); so the game doesn't declare a score-based winner on the console, it's only evident in ranklog. ** (I also find the logic in check_for_game_over() hard to follow, and I suspect it could be simplified.) (By the way, the decision that endgame etc were a draw came in in PR#14274, r11430 <http://svn.gna.org/viewcvs/freeciv?revision=11430&view=revision>, in 2006.) _______________________________________________________ Reply to this item at: <http://gna.org/bugs/?18084> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list [email protected] https://mail.gna.org/listinfo/freeciv-dev
