URL:
<http://gna.org/patch/?3658>
Summary: Nationality boolean check
Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 03 Feb 2013 02:31:47 AM EET
Category: general
Priority: 5 - Normal
Status: Ready For Test
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 2.4.0, 2.5.0
_______________________________________________________
Details:
Many places of the code check boolean setting game.info.citizen_nationality to
be exactly TRUE, i.e., 1. That's dangerous way to treat boolean even though
I'm not aware of it having any actual bad effects in this particular case
(value assigned to variable is never other than FALSE/0 or TRUE/1).
Attached patch fixes all those checks to check any boolean true value instead
of just TRUE/1.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Sun 03 Feb 2013 02:31:47 AM EET Name: NationalityTrueness.patch Size:
8kB By: cazfi
<http://gna.org/patch/download.php?file_id=17109>
-------------------------------------------------------
Date: Sun 03 Feb 2013 02:31:47 AM EET Name: NationalityTrueness-S2_4.patch
Size: 8kB By: cazfi
<http://gna.org/patch/download.php?file_id=17110>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3658>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
