URL:
  <http://gna.org/patch/?3685>

                 Summary: dio_get_xxx() returned value
                 Project: Freeciv
            Submitted by: pepeto
            Submitted on: dim. 10 févr. 2013 13:24:16 CET
                Category: general
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 

    _______________________________________________________

Details:

From bug #20003:
>> IIRC return value is solely about whether data was available
>> (and read). These low-level functions do not know what data is
>> valid. Maybe dio_get_uint8() has a bug?
>
> I think so. I will try to investigate a bit deeper...

dio_get_uint8() may be wrong when 'dest' argument is NULL. After having
checked everywhere this function is called in the current code, it never
should be problematic.

So, the attached patch shouldn't fix anything, except that the returned value
is always what it is supposed to be.

I attach a version for S2_4 too.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: dim. 10 févr. 2013 13:24:16 CET  Name: trunk_dio_get_xxx.diff  Size: 18
ko   By: pepeto

<http://gna.org/patch/download.php?file_id=17171>
-------------------------------------------------------
Date: dim. 10 févr. 2013 13:24:16 CET  Name: S2_4_dio_get_xxx.diff  Size: 18
ko   By: pepeto

<http://gna.org/patch/download.php?file_id=17172>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?3685>

_______________________________________________
  Message posté via/par Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to