URL: <http://gna.org/patch/?3691>
Summary: Handle lookup_req_list errors Project: Freeciv Submitted by: cazfi Submitted on: Mon 11 Feb 2013 02:31:45 AM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0, 2.5.0 _______________________________________________________ Details: Handle all errors in lookup_req_list() gracefully. S2_4 goes the opposite direction. There is no way to handle errors gracefully, but ignoring the errors as the old code does is not good either. It was just ignoring illegal requirements. It's better to make errors known to ruleset author by aborting upon them than silently running with broken ruleset (missing requirement that author meant to be there, maybe simply because typo in name). _______________________________________________________ File Attachments: ------------------------------------------------------- Date: Mon 11 Feb 2013 02:31:45 AM EET Name: HandleLookupReqListErrors.patch.bz2 Size: 6kB By: cazfi <http://gna.org/patch/download.php?file_id=17181> ------------------------------------------------------- Date: Mon 11 Feb 2013 02:31:45 AM EET Name: FatalReqListErrors-S2_4.patch Size: 2kB By: cazfi <http://gna.org/patch/download.php?file_id=17182> _______________________________________________________ Reply to this item at: <http://gna.org/patch/?3691> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev