URL:
  <http://gna.org/bugs/?20512>

                 Summary: Number of barbarian units created bugs
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Fri 15 Feb 2013 02:22:17 PM EET
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: None
         Planned Release: 

    _______________________________________________________

Details:

- try_summon_barbarians() sets 'uprise' to 3 if player has more than
UPRISE_CIV_MOST cities, but it does so only after old value (initialization to
1) of 'uprise' has already been used to decide number of barbarians to create
- if fc_rand(100) > get_player_bonus(victim, EFT_CIVIL_WAR_CHANCE),
try_summon_barbarians() will not create any barbarians. That's probably
opposite from what was meant - CIVIL_WAR_CHANCE of 100% will mean that
fc_rand(100) can never be bigger than it whereas CIVIL_WAR_CHANCE of 0% means
that barbarians are always created.




    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?20512>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to