Follow-up Comment #12, bug #20498 (project freeciv):

> I can't actually see how unit_list_iterate could do the wrong
> thing here, where only the current unit can be removed.

Maybe so, I had no reproducible case to test against. But then, as far as I
can see, unit.c assert can happen only if unit_transport_unload() fails to
remove unit from the list -> list size > 0 even after unit_transport_unload()
called for all units in it.

> I don't see anything in the committed change about moving
> functionality out of asserts

unit.c:
fc_assert(unit_transport_unload(pcargo)); ->
unit_transport_unload(pcargo);


    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?20498>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to